Make most evaluation results subfields nullable #342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when requesting evaluation results for count mode detectors
f-wright
reviewed
Apr 2, 2025
Contributor
f-wright
left a comment
f-wright
left a comment
There was a problem hiding this comment.
When you say "manual" changes, did you generate a spec and copy it over from zuuul, or change it directly? We keep those two versions of the API spec in sync, so we don't want to make actual manual changes here.
Contributor
Author
I did not know that -- will do it correctly now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make most evaluation results subfields nullable to avoid ApiTypeErrors when requesting evaluation results for count mode detectors.
Most changes were automatically generated. The only manual changes are inside
spec/public_api.yaml