New code.groundlight.ai landing page

[mdmunnaahmed]

No description provided.

[mdmunnaahmed]

home page design is done and ready to preview

[tyler-romero]

Thank you!

I notice that when I build the site there are two Header bars, can you fix that?

Other than that, just a few minor comments around style/naming.

[tyler-romero]

Same issue at the bottom of the page - two footers are rendered:

[tyler-romero]

Getting close, thank you!

Now the code.groundlight.ai landing page looks great, but the style of all of the other pages has changed, which is not desired.

For example, here is the before and after of the "Getting Started" page:

Before (what we want to keep):

After (undesired change):

[tyler-romero]

Hi Munna, I see you pushed an update but the issue is not fixed:

Some things to note:

1. Page color theme does not match header color theme when light color theme is activated. In particular the page background color is dark when it should be light.
2. Color theme switcher is white when header is white - which makes it hidden. It should be black when the header is white.
3. In general things look correct when the dark color theme is activated, but when the light color theme (the default) is activated things are wrong.

[mdmunnaahmed]

strange! i can't define how they were before. i just included the style file in the index file only. how it could affect others. let me try another way. thank you for the feedback.

…

On Mon, Dec 2, 2024 at 12:03 AM Tyler Romero ***@***.***> wrote: Hi Munna, I see you pushed an update but the issue is not fixed: Some things to note: 1. Page color theme does not match header color theme 2. Color theme switcher is white when header is white - which makes it hidden. It should be black when the header is white. 3. In general things look correct when the dark color theme is activated, but when the light color theme (the default) is activated things are wrong. image.png (view on web) <https://github.com/user-attachments/assets/530776fd-77f4-4208-8f34-61bf4a99f31d> — Reply to this email directly, view it on GitHub <#278 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASAOH3TX5YNHQA4JHCQZPK32DNFOFAVCNFSM6AAAAABSOT4NFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJQGE3TSNZUGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tyler-romero]

Please tag me or click re-request review when ready for me to take a look again. Thanks!

[tyler-romero]

Hi Munna,

Thanks for another update. However, the issue as outlined above persists. Are you able to build the site with make develop-docs-comprehensive? If so, you can replicate this issue by simply clicking "Docs" from the landing page.

[tyler-romero]

Please re-request a review when you have resolved this issue, or tag me directly if you have any questions.

[mdmunnaahmed]

hi Tyler, i think the issue is finally resolved. please take a look now.

…

On Tue, Dec 3, 2024 at 11:26 PM Tyler Romero ***@***.***> wrote: ***@***.**** requested changes on this pull request. Please re-request a review when you have resolved this issue, or tag me directly if you have any questions. — Reply to this email directly, view it on GitHub <#278 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASAOH3XXLMIY6GXFUIDCCN32DXSULAVCNFSM6AAAAABSOT4NFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZWGM2TKNZVG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tyler-romero]

Hi Munna, thanks for your efforts, however the issue has just been shifted around. Now the landing page is incorrect again. Next time please click around and do some quality assurance before re-requesting a review.

[mdmunnaahmed]

i checked it again and again, it shouldn't be. let me show you!

…

On Wed, Dec 4, 2024 at 12:58 AM Tyler Romero ***@***.***> wrote: ***@***.**** commented on this pull request. Hi Munna, thanks for your efforts, however the issue has just been shifted around. Now the landing page is incorrect again: image.png (view on web) <https://github.com/user-attachments/assets/fcde7821-67c2-4a6d-b050-230823c44744> — Reply to this email directly, view it on GitHub <#278 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASAOH3WI4ZO2RJKJHY3IFWT2DX5N5AVCNFSM6AAAAABSOT4NFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZWGU2TENZVGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tyler-romero]

LGTM, thanks Lucho! Just one comment about fixing the names/prefixes of some CSS classes then we can merge.

[tyler-romero]

In an effort to fix the styling, it looks like Munna added a prefix to a bunch of these css classes: 011ae98 (#278)

Can we clean this up by doing one of the following:

1. Using a better prefix that isn't a name/alias? Maybe like "landingpage" if these all pertain to the landing page.
2. Wrapping in some sort of namespace? Is this a thing in css?

[waldron258]

As a suggestion, I don't think we need this prefix anymore. I'm testing by removing them and it works perfect. Please let me know if this suggestions works for you.

[tyler-romero]

Yeah sounds good!