Skip to content

Makes the SDK communicate over the wire with YES/NO #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brandon-wada wants to merge 3 commits into from
Closed

Makes the SDK communicate over the wire with YES/NO #202

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
724856c
Makes the SDK communicate over the wire with the proper label value s…
Apr 9, 2024
1e80fbf
Merge branch 'main' into change_label_value_wire_format
Nov 14, 2024
08b74ae
Merge branch 'main' into change_label_value_wire_format
Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/groundlight/binary_labels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ def convert_display_label_to_internal(
if not isinstance(label, str):
raise ValueError(f"Expected a string label, but got {label} of type {type(label)}")
upper = label.upper()
if upper == Label.YES:
return DeprecatedLabel.PASS.value
if upper == Label.NO:
return DeprecatedLabel.FAIL.value
if upper in {Label.YES.value, Label.NO.value}:
return upper

raise ValueError(f"Invalid label string '{label}'. Must be one of '{Label.YES.value}','{Label.NO.value}'.")
Loading