Skip to content

Add/agent control scan config defaults#1303

Open
ozgen wants to merge 2 commits intomainfrom
add/agent-control-scan-config-defaults
Open

Add/agent control scan config defaults#1303
ozgen wants to merge 2 commits intomainfrom
add/agent-control-scan-config-defaults

Conversation

@ozgen
Copy link
Member

@ozgen ozgen commented Mar 6, 2026

What

  • Updated modify_agent_control_scan_config to support the new config_defaults XML structure (<config_defaults>, <agent_defaults>, and <agent_control_defaults>).
  • Added support for the sync_agents command which triggers agent synchronization and sends a simple <sync_agents/> request.

Why

The agent-controller API changed and introduced the new config_defaults structure, so pythin-gvm must be updated to stay compatible.

References

GEA-1635
greenbone/gvmd#2813
greenbone/gvm-libs#1056

Checklist

  • Tests

ozgen added 2 commits March 6, 2026 14:39
wrapping values under <config_defaults>
serializing nested <agent_defaults>
serializing <agent_control_defaults>
encoding update_to_latest as 1 / 0
handling scheduler_cron_time as a list with is_list="1"
@ozgen ozgen requested a review from a team as a code owner March 6, 2026 13:45
@greenbonebot greenbonebot enabled auto-merge (rebase) March 6, 2026 13:46
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA f700154.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Conventional Commits Report

Type Number
Added 1
Changed 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 81.48148% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.20%. Comparing base (7255f92) to head (f700154).

Files with missing lines Patch % Lines
gvm/protocols/gmp/requests/next/_agents.py 80.76% 4 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
- Coverage   98.33%   98.20%   -0.14%     
==========================================
  Files          89       89              
  Lines        6197     6238      +41     
  Branches     1112     1120       +8     
==========================================
+ Hits         6094     6126      +32     
- Misses         74       78       +4     
- Partials       29       34       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant