Handle PIDs in messages and message prefixes #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Field 1 on the default HAProxy log format is set as `process_name '[' pid ']:'` which is also displayed in the example message in README. The existing rules do not allow for the PID brackets. This commit properly resolves them while also maintaining backwards compatibility for a PID-less log format.
In case there is a prefix applied to the message, the `^haproxy` condition match would fail. There are already some of the extractors which have dropped the line-start requirement from their regular expressions. This commit removes the requirement from all the extractors for consistency and input flexibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided example includes a message using the default log format. This includes a PID next to the process name such as
haproxy[1234]:which does not currently get properly parsed. Additionally, some extractors already work for messages with prefixes (such as datetime being added there) while others do not, therefore this PR adds consistency by dropping the^line-start requirement.