fix: resolve AppContext memory leak for direct app.express handlers#117
Merged
Conversation
DakEnviy
reviewed
May 18, 2026
DakEnviy
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the per-request
AppContextcleanup (res.on('close', () => req.originalContext.end())) only happens insiderouteInfoMiddleware. This middleware is only attached per-route duringsetupRoutes.If consumers register handlers directly on
app.express(e.g.,app.express.get('/healthz', handler), they bypasssetupRoutes. As a result, every request to these bare routes permanently leaks:'abort'event listener on the long-lived rootnodekit.ctx.abortSignalAppContextinstanceSpanSolution
This PR moves the per-request
AppContextcleanup hook from the per-routerouteInfoMiddlewareinto the globalsetupBaseMiddleware.Because
setupBaseMiddlewareis the same place the context is originally created, the cleanup will now reliably run for every request that hits the Express app, regardless of how the handler was registered.