Feature: Support Union in DjangoFilterConnectionField and DjangoConnectionField#1537
Open
that-one-arab wants to merge 4 commits intographql-python:mainfrom
Open
Feature: Support Union in DjangoFilterConnectionField and DjangoConnectionField#1537that-one-arab wants to merge 4 commits intographql-python:mainfrom
that-one-arab wants to merge 4 commits intographql-python:mainfrom
Conversation
ulgens
requested changes
Nov 10, 2024
this change makes things more consistent and prevent possible issues with 3rd party libraries
Author
|
@ulgens I made the changes as requested, can you please re-review when you can? |
Author
|
@ulgens @jaw9c @kiendang @mahdyhamad What are your opinions on this PR? Should I close it? |
|
this feature would be really helpful. any chance we can get some sort of update on this. |
Collaborator
|
@that-one-arab @waema I don't have my maintainer rights anymore and I can't help to move this forward. That being told, I wouldn't recommend spending time on graphene anymore. The project was dead ~6 years ago, I tried to keep it alive for a brief of period of time and it didn't work. Not having the repo archived is just misleading at this point. Another related discussion can be found here: #1394 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was previously mentioned here
The purpose of this PR is to make Union types compatible with DjangoFilterConnectionFields so that we can query a root model that is resolved to other model types in runtime, supporting libraries like django-polymorphic
Here's an example of what this PR achieves:
Previously,
DjangoFilterConnectionFieldonly acceptedDjangoObjectTypesandDjangoObjectTypesdo not support unions.Has this PR dependancy that needs merging for the feature to work
NOTE: Tests are failing because it depends on the aforementioned PR!