Skip to content

Change to file-scoped namespaces#773

Merged
Shane32 merged 1 commit intodevelopfrom
file_scoped_namespaces
Apr 14, 2022
Merged

Change to file-scoped namespaces#773
Shane32 merged 1 commit intodevelopfrom
file_scoped_namespaces

Conversation

@Shane32
Copy link
Copy Markdown
Member

@Shane32 Shane32 commented Apr 14, 2022

This PR contains no changes other than conversion to file-scoped namespaces, so as to reduce diff for future changes.

@Shane32 Shane32 requested a review from sungam3r April 14, 2022 16:54
@Shane32 Shane32 self-assigned this Apr 14, 2022
@Shane32
Copy link
Copy Markdown
Member Author

Shane32 commented Apr 14, 2022

Use 'hide whitespace' to view reduce diff in GitHub preview.

@Shane32 Shane32 added code style Pull request that applies code style rules and removed performance test labels Apr 14, 2022
@sungam3r
Copy link
Copy Markdown
Member

It will break all PRs. I intentionally did not change namespaces. Or do you mean that all current PRs will be rejected or solved by further changes?

@Shane32
Copy link
Copy Markdown
Member Author

Shane32 commented Apr 14, 2022

Well..... uhhh.... I dunno. I just am trying to help you review my PR(s).

#733 -- needs to be redone in light of serialization libraries have been moved to GraphQL.NET repo - most likely this code needs to be added to GraphQL.NET repo
#694 -- obsolete with my new subscription code
#587 -- only contains a couple lines of code that were changed
#515 -- one file is new; the other is easily merged with any changes
#279 -- obsolete with my new subscription code
#195 -- this is 3 years old now

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 48.62249% with 690 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.93%. Comparing base (ce77ad1) to head (aab2e1b).
⚠️ Report is 190 commits behind head on develop.

Files with missing lines Patch % Lines
...ubscriptions.WebSockets/WebSocketReaderPipeline.cs 0.00% 84 Missing ⚠️
...rization.AspNetCore/AuthorizationValidationRule.cs 50.00% 48 Missing and 7 partials ⚠️
...NetCore/DefaultAuthorizationErrorMessageBuilder.cs 42.85% 32 Missing and 4 partials ⚠️
.../Extensions/GraphQLBuilderUserContextExtensions.cs 0.00% 33 Missing ⚠️
src/Ui.Playground/Internal/PlaygroundPageModel.cs 0.00% 33 Missing ⚠️
src/Transports.AspNetCore/GraphQLHttpMiddleware.cs 81.60% 22 Missing and 10 partials ⚠️
....Subscriptions.Abstractions/SubscriptionManager.cs 73.26% 20 Missing and 7 partials ⚠️
...criptions.WebSockets/WebSocketConnectionFactory.cs 0.00% 26 Missing ⚠️
src/Ui.Playground/PlaygroundOptions.cs 47.91% 24 Missing and 1 partial ⚠️
src/Ui.GraphiQL/Internal/GraphiQLPageModel.cs 0.00% 24 Missing ⚠️
... and 37 more
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #773   +/-   ##
========================================
  Coverage    47.93%   47.93%           
========================================
  Files           50       50           
  Lines         1552     1552           
  Branches       174      174           
========================================
  Hits           744      744           
  Misses         752      752           
  Partials        56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code style Pull request that applies code style rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants