Suport for Multiple Databases in one GCP project#167
Open
radzisz wants to merge 2 commits intograhamearley:mainfrom
Open
Suport for Multiple Databases in one GCP project#167radzisz wants to merge 2 commits intograhamearley:mainfrom
radzisz wants to merge 2 commits intograhamearley:mainfrom
Conversation
|
I was gonna implement your code in my repo and noticed two things. |
Author
|
It is to conform with a Google spec - not my invention :-)
…On Fri, Feb 28, 2025 at 3:41 PM abkarino ***@***.***> wrote:
I was gonna implement your code in my repo and noticed two things.
x-goog-request-params header is added, I am not quite sure why this was
added. I tried the base code without the header and it didn't throw any
errors.
Although I see you modified tests, some tests fail since the doc.path
getter will not match since it relies on regex so you need to modify it
there.
—
Reply to this email directly, view it on GitHub
<#167 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRJBDYAQT3O2TPTKYZUDSD2SBYS3AVCNFSM6AAAAABYCPBDWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJQHAYTENBRG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: abkarino]*abkarino* left a comment
(grahamearley/FirestoreGoogleAppsScript#167)
<#167 (comment)>
I was gonna implement your code in my repo and noticed two things.
x-goog-request-params header is added, I am not quite sure why this was
added. I tried the base code without the header and it didn't throw any
errors.
Although I see you modified tests, some tests fail since the doc.path
getter will not match since it relies on regex so you need to modify it
there.
—
Reply to this email directly, view it on GitHub
<#167 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRJBDYAQT3O2TPTKYZUDSD2SBYS3AVCNFSM6AAAAABYCPBDWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJQHAYTENBRG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple change enabling access to multiple databases.
It is fully backward compatible.