Allow preserveExisting existing to be combined with other features #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jjohannes
commented
Jan 27, 2026
jjohannes
commented
- removePackage: remove exports of package from existing module-info (fixes removePackage should also remove the export for the package if it exists #219)
- ignoreServiceProvider: remove ignored providers from module-info (fixes ignoreServiceProvider should also remove the providers from existing module-info #223)
✅ All tests passed ✅🏷️ Commit: 3127932 Learn more about TestLens at testlens.app. |
jjohannes
force-pushed
the
219-preserveExisting-combined
branch
from
2eabb95 to
16aaa04
Compare
- removePackage: remove exports of package from existing module-info - ignoreServiceProvider: remove ignored providers from module-info
jjohannes
force-pushed
the
219-preserveExisting-combined
branch
from
16aaa04 to
3127932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.