Skip to content

Ensure WorkgroupSizeX never exceeds the maximum in subgroup size control tests#4655

Merged
kainino0x merged 1 commit into
gpuweb:mainfrom
Jiawei-Shao:fix-subgroup-size-control-test
Jun 2, 2026
Merged

Ensure WorkgroupSizeX never exceeds the maximum in subgroup size control tests#4655
kainino0x merged 1 commit into
gpuweb:mainfrom
Jiawei-Shao:fix-subgroup-size-control-test

Conversation

@Jiawei-Shao
Copy link
Copy Markdown
Collaborator

Issue: #4640


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [*] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@Jiawei-Shao Jiawei-Shao requested review from jrprice and kainino0x June 2, 2026 06:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Results for build job (at 8bfd112):

 Test case/subcase counts did not change.

@kainino0x kainino0x merged commit 9964a05 into gpuweb:main Jun 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants