-
Notifications
You must be signed in to change notification settings - Fork 102
Swizzle assignment tests #4580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swizzle assignment tests #4580
Conversation
|
Results for build job (at 5bc7e84): +webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:* - 13 cases, 13 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_other_vars:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_chained:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_pointer:* - 1 cases, 1 subcases (~1/case)
+webgpu:shader,execution,statement,swizzle_assignment:swizzle_compound_assignment:* - 1 cases, 1 subcases (~1/case)
-webgpu:shader,validation,parse,requires:wgsl_matches_api:* - 8 cases, 8 subcases (~1/case)
+webgpu:shader,validation,parse,requires:wgsl_matches_api:* - 9 cases, 9 subcases (~1/case)
-TOTAL: 285935 cases, 2344828 subcases
+TOTAL: 285953 cases, 2344846 subcases |
b95f0b5 to
8ef7fcf
Compare
alan-baker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add TODOs or unimplemented test suites for the following:
- Other address spaces (only function is tested currently)
- Chained swizzles
- Pointer to swizzle
src/webgpu/shader/execution/statement/swizzle_assignment.spec.ts
Outdated
Show resolved
Hide resolved
8ef7fcf to
f289594
Compare
Done and updated tracking bug |
f289594 to
c7b5d6b
Compare
|
Fixed TODOs to make the linter happy and a placeholder validation test file |
c7b5d6b to
e8b5f8f
Compare
Generators didn't seem to like an empty test file so removed that, still tracking need for validation tests in Issue #4579 |
e8b5f8f to
1a12203
Compare
1a12203 to
5ecf1c3
Compare
5ecf1c3 to
5bc7e84
Compare
Add some initial valid swizzle assignment tests on basic var vectors.
These tests pass on my current WIP implementation of the feature locally.
Issue: #4579
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.