Allow skipIfTextureFormatNotSupported in beforeAllSubcases#4431
Draft
kainino0x wants to merge 3 commits intogpuweb:mainfrom
Draft
Allow skipIfTextureFormatNotSupported in beforeAllSubcases#4431kainino0x wants to merge 3 commits intogpuweb:mainfrom
kainino0x wants to merge 3 commits intogpuweb:mainfrom
Conversation
Collaborator
Author
|
@greggman just a draft but WDYT |
Contributor
|
lgtm are you planning to go through and refactor all the current tests doing late filtering? I'm not sure about the skipIf_____ubound pattern. It works but seems convoluted? Like how about just skipIfNotX(device: GPUDevice, params) { ... }And then class GPUTestBase {
skipIfNotX(params) { skipIfNotX(this.device, params); }
}Though I'm not against the ___ubound pattern. I just had to dig through the code to figure out why |
Contributor
|
And also, do we want to discourage late filtering? Maybe we should require these to be called between init and postInit in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 separately reviewable commits
Probably needs more testing
Issue: #4424
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.