Conversation
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
| @@ -1,4 +1,4 @@ | |||
| PROJECT=gotify/build | |||
| PROJECT=docker.io/gotify/build | |||
| GO_VERSION?=$(shell cat GO_VERSION) | |||
There was a problem hiding this comment.
FYI: I'll wait on musl support for the next gotify/server release.
There was a problem hiding this comment.
@eternal-flame-AD FYI: I'll create a release today, as the new plugin support probably will take some time to fully work.
| ENV CGO_ENABLED=1 | ||
| ENV GOOS=linux | ||
| ENV GOARCH=amd64 | ||
| ENV GO_EXTRA_LDFLAGS="-linkmode external -extldflags '-static'" |
There was a problem hiding this comment.
This isn't a standard Go environment variable correct? I think I'll wait for the gotify/server changes required to make this work. Without the big picture this is difficult to review.
There was a problem hiding this comment.
Yes, we have to add this to the Makefile. My testing is simply add this to DOCKER_GO_BUILD and it builds correctly.
If you agree with the plugin transition I think let's just get the plugin issue out of the way first to fix the documentation issue, I tried finding a way to query at runtime whether the program is statically linked it isn't that simple, I don't want to add a permanent magic linker flag to solve a temporary problem.
2 participants
Fixes #17