fix: StyleSheet absoluteFill instead of deprecated absoluteFillObject#2637
Merged
gorhom merged 2 commits intogorhom:masterfrom Apr 8, 2026
Merged
fix: StyleSheet absoluteFill instead of deprecated absoluteFillObject#2637gorhom merged 2 commits intogorhom:masterfrom
gorhom merged 2 commits intogorhom:masterfrom
Conversation
1e5dcac to
b026e2d
Compare
gorhom
requested changes
Apr 8, 2026
Owner
gorhom
left a comment
There was a problem hiding this comment.
i would recommend keeping this PR only for replacing the deprecated API not formatting the entire code base
| ANIMATION_STATUS, | ||
| GESTURE_SOURCE, | ||
| KEYBOARD_STATUS, | ||
| SCROLLABLE_STATUS, |
| "react-native-reanimated": ">=3.16.0 || >=4.0.0-" | ||
| }, | ||
| "peerDependenciesMeta": { | ||
| "@types/react-native": { |
Owner
There was a problem hiding this comment.
could you please revert this change
Owner
There was a problem hiding this comment.
could you please revert this file too
b026e2d to
cb11232
Compare
gorhom
approved these changes
Apr 8, 2026
Owner
|
thanks @huextrat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide enough information so that others can review your pull request:
Motivation
Explain the motivation for making this change. What existing problem does the pull request solve?