Conversation
doanhtu07
changed the title
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Please don't close this PR! |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Please don't close this PR! |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Please don't close this PR! |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Please don't close this PR! |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Please don't close this PR! |
- Fix gorhom#2640: INITIAL_POSITION now uses Math.max(SCREEN_HEIGHT, WINDOW_HEIGHT) to handle web viewport resizing - Fix gorhom#2533: Account for scrollableContentOffsetY when calculating destinationPoint to fix scroll jumpy issue; change map to forEach for biome compliance
gorhom
force-pushed
the
fix/bottom-sheet-scroll-jumpy
branch
from
7cc0398 to
969cc16
Compare
|
thanks @doanhtu07 this is a good improvement ! |
2 participants
Motivation
When using BottomSheetScrollView, I ran into a strange issue.
During a long scroll, the pan gesture reads the same scroll distance. So when you try to scroll to the top, the bottom sheet mistakenly thinks you've already dragged it a long way. As a result, the sheet closes prematurely, which feels unintuitive.
Solution
Simply take into account
scrollableContentOffsetYduring calculatingdestinationPointScreenshots
Close too soon
close-too-soon.mp4
Solution demo
solution-demo.mp4
Sidenote
maptoforEachsince biome is complaining and failing the husky pipeline