Skip to content

Conversation

Copy link
Collaborator

@Liedtke Liedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run the tests (locally this will require either some fairly recent node version or a d8 executable) and fix the current failures?

I assume all this features are already available in V8 at least behind a flag, otherwise that will be another reason why these tests can fail.

"getUint16" : [.integer] => .integer,
"getInt32" : [.integer] => .integer,
"getUint32" : [.integer] => .integer,
"getFloat16" : [.integer] => .float,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not enough to add it to the ObjectGroup. It will also need to be added to the ILType (around line 1072).
This may seem like an unnecessary duplication (and I think it is) but that's how it works right now. :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks 👍

@linusg
Copy link
Author

linusg commented Jan 29, 2026

Could you please run the tests (locally this will require either some fairly recent node version or a d8 executable) and fix the current failures?

Will do - I did test this locally but only with a normal fuzzilli release build, hence why I missed the assertion.

I assume all this features are already available in V8 at least behind a flag, otherwise that will be another reason why these tests can fail.

Did a quick check of the implementation status:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants