Skip to content

Conversation

@Moemen02
Copy link

@Moemen02 Moemen02 commented Jan 2, 2026

  • Updated NavForwardingManager to include NavigationUpdatesOptions
    for improved navigation updates.

  • Enhanced ObjectTranslationUtil to extract and map lane information
    from StepInfo, including lane directions and recommendations.

  • Refactored multiple method signatures in iOS modules
    for consistency and clarity.

This PR enhances the onTurnByTurn event payload by adding optional lane guidance
data (lanes) so developers can build fully custom turn-by-turn guidance UI
(e.g. a lane row showing which lanes are recommended) instead of relying solely
on the default Google UI.

Example lanes payload (when available):

[
  { "laneDirections": [ { "recommended": true,  "laneShape": 4 } ] },
  { "laneDirections": [ { "recommended": false, "laneShape": 1 } ] },
  { "laneDirections": [ { "recommended": false, "laneShape": 1 } ] }
]

Notes:

  • lanes is not always present. The Navigation SDK only provides lane guidance
    for certain maneuvers/segments, so consumers should treat it as optional.
  • This is an additive change to the onTurnByTurn event and does not remove or
    change existing fields.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation
  • I added new tests to check the change I am making
  • All existing and new tests are passing.

- Updated NavForwardingManager to include NavigationUpdatesOptions

  for improved navigation updates.

- Enhanced ObjectTranslationUtil to extract and map lane information

  from StepInfo, including lane directions and recommendations.

- Refactored multiple method signatures in iOS modules

  for consistency and clarity.
@jokerttu jokerttu self-assigned this Jan 5, 2026
@jokerttu jokerttu requested review from illuminati1911 and jokerttu and removed request for jokerttu January 9, 2026 15:32
Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Moemen02,

First of all, I apologize for the late review on this PR.
Adding @illuminati1911 as a second reviewer.

I've reviewed the implementation and it looks good already.

I noticed that this PR contains a significant amount of unrelated formatting changes, particularly in the iOS Objective-C files.

Could you please:

  1. Revert the unrelated formatting changes
  2. Use the project's formatting scripts as described in CONTRIBUTING.md:
    • For Objective-C: ./scripts/format-objc.sh

NavigationUpdatesOptions options =
NavigationUpdatesOptions.builder()
.setNumNextStepsToPreview(Integer.MAX_VALUE)
.setGeneratedStepImagesType(GeneratedStepImagesType.BITMAP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t handle GeneratedStepImagesType yet, so we could default to GeneratedStepImagesType.NONE That said, I’m leaning toward BITMAP, since it already lets developers use the generated bitmaps for Android Auto if needed.

@illuminati1911 any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants