fix: address lint, compiler, and Error Prone warnings#1692
Merged
Conversation
- Add missing `@Override` annotations to `RenderTask#run` and KML/GeoJSON Layer methods. - Resolve `LockNotBeforeTry` warnings in clustering renderers by moving lock acquisition outside of `try` blocks and ensuring release inside `finally` blocks. - Specify `Locale.ROOT` for filename casing comparisons in `KmlLayer` to satisfy `StringCaseLocaleUsage`. - Refactor KML ground overlay mapping to collect updates before applying, preventing ConcurrentModificationExceptions during iteration. - Sort imports in `KmlLayer` alphabetically to satisfy strict Checkstyle `ImportOrder` checks. - Address generic rawtype compiler warnings by cleaning up `KmlContainerParser` generics and using safe suppression in `GeoJsonLayer`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses various lint, compiler (generics/rawtypes), and Error Prone warnings across DefaultAdvancedMarkersClusterRenderer, DefaultClusterRenderer, KmlLayer, KmlRenderer, and GeoJsonLayer.
These changes ensure clean compile hygiene and safety under modern generics and strict locking checks.