Skip to content

Added region tags to 3D samples#1458

Merged
willum070 merged 8 commits into
mainfrom
region-tags
May 13, 2026
Merged

Added region tags to 3D samples#1458
willum070 merged 8 commits into
mainfrom
region-tags

Conversation

@oppenheimera
Copy link
Copy Markdown
Contributor

No description provided.

@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented May 13, 2026

Here is the summary of changes.

You are about to add 15 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@oppenheimera oppenheimera requested a review from willum070 May 13, 2026 17:05
Copy link
Copy Markdown
Collaborator

@willum070 willum070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made comments on a couple of files, but they are globally applicable. Essentially the sub region tags should all begin with the name of the main containing tag, and append. That way you always know which sample a particular region is associated with (macros are viewed out of context, you don't want to make maintainers resort to grepping), and also prevent the possibility of weird issues on the tooling side (not sure if it would but I would err on the side of caution).

Comment thread samples/3d-camera-to-around/index.ts Outdated
Comment thread samples/3d-camera-to-around/index.ts Outdated
Comment thread samples/3d-marker-collision-behavior/index.ts Outdated
Comment thread samples/3d-marker-customization/index.ts Outdated
@oppenheimera oppenheimera requested a review from willum070 May 13, 2026 20:14
Copy link
Copy Markdown
Collaborator

@willum070 willum070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks!

@willum070 willum070 merged commit dfec2c4 into main May 13, 2026
7 checks passed
@oppenheimera oppenheimera deleted the region-tags branch May 13, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants