Added region tags to 3D samples#1458
Conversation
|
Here is the summary of changes. You are about to add 15 region tags.
This comment is generated by snippet-bot.
|
willum070
left a comment
There was a problem hiding this comment.
I made comments on a couple of files, but they are globally applicable. Essentially the sub region tags should all begin with the name of the main containing tag, and append. That way you always know which sample a particular region is associated with (macros are viewed out of context, you don't want to make maintainers resort to grepping), and also prevent the possibility of weird issues on the tooling side (not sure if it would but I would err on the side of caution).
willum070
left a comment
There was a problem hiding this comment.
Looks awesome, thanks!
No description provided.