Skip to content

fix: Fixes an edge case and formatting. #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willum070 merged 9 commits into from
May 13, 2026
Merged

fix: Fixes an edge case and formatting. #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cf4c1c0
fix: Clamps tilt value to prevent error.
willum070 May 12, 2026
e5b1214
Reformat Google Maps API script loading tag
willum070 May 12, 2026
a97926e
Fix label formatting for tilt control
willum070 May 12, 2026
0b204e8
Simplify tilt change event listener
willum070 May 12, 2026
c35b90b
Refactor tilt calculation in updateUI function
willum070 May 12, 2026
b2ce2eb
Fix label formatting in 3D camera position UI
willum070 May 13, 2026
f994ec1
Refactor property assignment for map3DElement
willum070 May 13, 2026
7a8a169
Merge branch 'main' into fix-3d-camera-position
willum070 May 13, 2026
a56c645
Merge branch 'main' into fix-3d-camera-position
willum070 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions samples/3d-camera-position/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,12 @@
<title>Google Maps 3D - Camera Position Controller</title>
<link rel="stylesheet" type="text/css" href="./style.css" />
<script type="module" src="./index.js"></script>
<!-- prettier-ignore -->
<script>(g => { var h, a, k, p = "The Google Maps JavaScript API", c = "google", l = "importLibrary", q = "__ib__", m = document, b = window; b = b[c] || (b[c] = {}); var d = b.maps || (b.maps = {}), r = new Set, e = new URLSearchParams, u = () => h || (h = new Promise(async (f, n) => { await (a = m.createElement("script")); e.set("libraries", [...r] + ""); for (k in g) e.set(k.replace(/[A-Z]/g, t => "_" + t[0].toLowerCase()), g[k]); e.set("callback", c + ".maps." + q); a.src = `https://maps.${c}apis.com/maps/api/js?` + e; d[q] = f; a.onerror = () => h = n(Error(p + " could not load.")); a.nonce = m.querySelector("script[nonce]")?.nonce || ""; m.head.append(a) })); d[l] ? console.warn(p + " only loads once. Ignoring:", g) : d[l] = (f, ...n) => r.add(f) && u().then(() => d[l](f, ...n)) })
({ key: "AIzaSyA6myHzS10YXdcazAFalmXvDkrYCp5cLc8"});</script>
<script>
// prettier-ignore
(g=>{var h,a,k,p="The Google Maps JavaScript API",c="google",l="importLibrary",q="__ib__",m=document,b=window;b=b[c]||(b[c]={});var d=b.maps||(b.maps={}),r=new Set,e=new URLSearchParams,u=()=>h||(h=new Promise(async(f,n)=>{await (a=m.createElement("script"));e.set("libraries",[...r]+"");for(k in g)e.set(k.replace(/[A-Z]/g,t=>"_"+t[0].toLowerCase()),g[k]);e.set("callback",c+".maps."+q);a.src=`https://maps.${c}apis.com/maps/api/js?`+e;d[q]=f;a.onerror=()=>h=n(Error(p+" could not load."));a.nonce=m.querySelector("script[nonce]")?.nonce||"";m.head.append(a)}));d[l]?console.warn(p+" only loads once. Ignoring:",g):d[l]=(f,...n)=>r.add(f)&&u().then(()=>d[l](f,...n))})({
key: "AIzaSyA6myHzS10YXdcazAFalmXvDkrYCp5cLc8"
});
</script>
</head>

<body>
Expand All @@ -25,9 +28,9 @@
<div id="ui-container">
<div class="panel">
<div class="control-group">
<label for="heading"
>Heading: <span id="heading-val">0</span>&deg;</label
>
<label for="heading">
Heading: <span id="heading-val">0</span>&deg;
</label>
<input
type="range"
id="heading"
Expand All @@ -39,9 +42,9 @@
</div>

<div class="control-group">
<label for="tilt"
>Tilt: <span id="tilt-val">45</span>&deg;</label
>
<label for="tilt">
Tilt: <span id="tilt-val">45</span>&deg;
</label>
Comment thread
willum070 marked this conversation as resolved.
<input
type="range"
id="tilt"
Expand All @@ -53,9 +56,9 @@
</div>

<div class="control-group">
<label for="range"
>Range: <span id="range-val">1000</span>m</label
>
<label for="range">
Range: <span id="range-val">1000</span>m
</label>
<input
type="range"
id="range"
Expand Down Expand Up @@ -92,9 +95,9 @@
</div>

<div class="control-group">
<label for="altitude"
>Altitude: <span id="altitude-val">30</span>m</label
>
<label for="altitude">
Altitude: <span id="altitude-val">30</span>m
</label>
<input
type="range"
id="altitude"
Expand All @@ -106,9 +109,9 @@
</div>

<div class="control-group">
<label for="fov"
>FOV: <span id="fov-val">35</span>&deg;</label
>
<label for="fov">
FOV: <span id="fov-val">35</span>&deg;
</label>
<input
type="range"
id="fov"
Expand All @@ -120,9 +123,9 @@
</div>

<div class="control-group">
<label for="roll"
>Roll: <span id="roll-val">0</span>&deg;</label
>
<label for="roll">
Roll: <span id="roll-val">0</span>&deg;
</label>
<input
type="range"
id="roll"
Expand Down
4 changes: 4 additions & 0 deletions samples/3d-camera-position/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,10 @@ async function initMap(): Promise<void> {
altitude: val,
};
}
} else if (prop === 'tilt') {
map3DElement.tilt = Math.max(0, val);
} else if (prop === 'fov') {
map3DElement.fov = Math.min(80, Math.max(5, val));
} else {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(map3DElement as any)[prop] = val;
Expand Down
Loading