Skip to content

feat: Migrates the dds-datasets-polygon-click sample.#1080

Open
willum070 wants to merge 12 commits intomainfrom
migrate-dds-datasets-polygon-click
Open

feat: Migrates the dds-datasets-polygon-click sample.#1080
willum070 wants to merge 12 commits intomainfrom
migrate-dds-datasets-polygon-click

Conversation

@willum070
Copy link
Collaborator

@willum070 willum070 commented Feb 6, 2026

This PR does the following things:

  • Migrates the dds-datasets-polygon-click sample to js-api-samples.
  • Refactors UI to be declarative-first.
  • Removes all ts-ignore comments.
  • Updates to use the weekly channel.
  • Updates map IDs and dataset IDs since now data artifacts reside on the maps-docs-team Pantheon project.

@snippet-bot
Copy link

snippet-bot bot commented Feb 6, 2026

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@willum070 willum070 requested a review from miraleung February 6, 2026 18:02
Remove unnecessary check for datasetAttributes in applyStyle function.
Temporarily comment out mousemove event listener for testing.
Done testing, sorry to say that didn't move the needle.
temporary change from 'globalid' to 'typecategory' in feature ID checks. This will help us to determine if globalid has a role in the 400 errors in the tests.
Reverted changes to use 'globalid' attribute for feature identification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants