Skip to content

chore(obs): use Span instead of AppCentric prefix for tracing#4117

Open
diegomarquezp wants to merge 1 commit intomainfrom
observability/rename-to-span
Open

chore(obs): use Span instead of AppCentric prefix for tracing#4117
diegomarquezp wants to merge 1 commit intomainfrom
observability/rename-to-span

Conversation

@diegomarquezp
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 19, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort to standardize the naming conventions for tracing components within the gax-java library. The primary objective is to replace the 'AppCentric' prefix with 'Span' for relevant classes, enhancing clarity and consistency with widely accepted distributed tracing concepts. This change improves the readability and maintainability of the tracing implementation, making it more intuitive for developers familiar with OpenTelemetry and similar systems.

Highlights

  • Class Renaming: The core tracing class AppCentricTracer has been renamed to SpanTracer to better align with standard observability terminology.
  • Factory Renaming: The associated factory class AppCentricTracerFactory has been renamed to SpanTracerFactory.
  • Codebase-Wide Updates: All references, instantiations, and test cases for the renamed classes have been updated across the gax-java and java-showcase modules.
Changelog
  • gax-java/gax/src/main/java/com/google/api/gax/tracing/AppCentricTracer.java
    • Renamed to SpanTracer.java
    • Updated class name, constructor, and Javadoc comments to SpanTracer
  • gax-java/gax/src/main/java/com/google/api/gax/tracing/AppCentricTracerFactory.java
    • Renamed to SpanTracerFactory.java
    • Updated class name, constructors, Javadoc, and internal instantiations to SpanTracerFactory and SpanTracer
  • gax-java/gax/src/test/java/com/google/api/gax/tracing/AppCentricTracerFactoryTest.java
    • Renamed to SpanTracerFactoryTest.java
    • Updated class name and references to SpanTracerFactory and SpanTracer
  • gax-java/gax/src/test/java/com/google/api/gax/tracing/AppCentricTracerTest.java
    • Renamed to SpanTracerTest.java
    • Updated class name and references to SpanTracer
  • java-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITOtelTracing.java
    • Updated import statements to use SpanTracer and SpanTracerFactory
    • Modified instantiations and attribute references to reflect the new class names
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully renames AppCentricTracer to SpanTracer and AppCentricTracerFactory to SpanTracerFactory, along with updating all corresponding references in the codebase, including tests and Javadoc. This change improves the clarity and consistency of the tracing components by aligning the naming with standard observability terminology. The refactoring is clean and does not introduce any functional regressions or new issues. All changes are consistent with the pull request's objective.

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments