Skip to content

fix: Replace asyncio.run with create_task in ADK async thread mains. #6236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jan 7, 2026
+9 −5
Merged

fix: Replace asyncio.run with create_task in ADK async thread mains. #6236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions vertexai/preview/reasoning_engines/templates/adk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,7 @@ async def _invoke_agent_async():

def _asyncio_thread_main():
try:
asyncio.run(_invoke_agent_async())
asyncio.get_running_loop().create_task(_invoke_agent_async())
except RuntimeError as e:
event_queue.put(e)
finally:
Expand Down Expand Up @@ -1225,7 +1225,9 @@ async def _invoke_async_get_session():

def _asyncio_thread_main():
try:
result = asyncio.run(_invoke_async_get_session())
result = asyncio.get_running_loop().create_task(
_invoke_async_get_session()
)
event_queue.put(result)
except RuntimeError as e:
event_queue.put(e)
Expand Down Expand Up @@ -1279,7 +1281,7 @@ async def _invoke_async_list_sessions():

def _asyncio_thread_main():
try:
asyncio.run(_invoke_async_list_sessions())
asyncio.get_running_loop().create_task(_invoke_async_list_sessions())
finally:
event_queue.put(None)

Expand Down Expand Up @@ -1349,7 +1351,9 @@ async def _invoke_async_create_session():

def _asyncio_thread_main():
try:
result = asyncio.run(_invoke_async_create_session())
result = asyncio.get_running_loop().create_task(
_invoke_async_create_session()
)
event_queue.put(result)
except RuntimeError as e:
event_queue.put(e)
Expand Down Expand Up @@ -1411,7 +1415,7 @@ async def _invoke_async_delete_session():

def _asyncio_thread_main():
try:
asyncio.run(_invoke_async_delete_session())
asyncio.get_running_loop().create_task(_invoke_async_delete_session())
event_queue.put(None)
except RuntimeError as e:
event_queue.put(e)
Expand Down
Loading