feat: resource autodetection for Cloud Run Jobs#1591
feat: resource autodetection for Cloud Run Jobs#1591Daniel-Aaron-Bloom wants to merge 2 commits intogoogleapis:mainfrom
Conversation
|
@bhshkh Is there something I should do to rectify this? These errors look maybe related to #1599? Also googleapis/google-auth-library-nodejs#2120 got merged, so I could bump |
@cindy-peng should be able to answer this. |
|
Ping @cindy-peng |
|
Tagging @danieljbruce @feywind |
|
Ping. |
|
Hi @Daniel-Aaron-Bloom! thanks for your help on this. Yes, I think upgrading auth is the most proper solution + will help with googleapis/google-cloud-node#7565. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Unfortunately
google-auth-librarydoesn't yet support Cloud Run Job detection. The workaround is pretty simple (basically the same as #1024 did by checking the env directly). Happy to submit a future PR to do the "more correct" detection once support gets merged. Maybe someone here knows an approver over there 😁 .Fixes googleapis/google-cloud-node#7566 🦕