feat: resource autodetection for Cloud Run Jobs#1591
Open
Daniel-Aaron-Bloom wants to merge 2 commits intogoogleapis:mainfrom
Open
feat: resource autodetection for Cloud Run Jobs#1591Daniel-Aaron-Bloom wants to merge 2 commits intogoogleapis:mainfrom
Daniel-Aaron-Bloom wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Author
|
@bhshkh Is there something I should do to rectify this? These errors look maybe related to #1599? Also googleapis/google-auth-library-nodejs#2120 got merged, so I could bump |
Contributor
@cindy-peng should be able to answer this. |
Author
|
Ping @cindy-peng |
Contributor
|
Tagging @danieljbruce @feywind |
Author
|
Ping. |
|
Hi @Daniel-Aaron-Bloom! thanks for your help on this. Yes, I think upgrading auth is the most proper solution + will help with #1592. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Unfortunately
google-auth-librarydoesn't yet support Cloud Run Job detection. The workaround is pretty simple (basically the same as #1024 did by checking the env directly). Happy to submit a future PR to do the "more correct" detection once support gets merged. Maybe someone here knows an approver over there 😁 .Fixes #1590 🦕