Skip to content

chore: Add gcp resource name span attribute #4306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahul2393 merged 3 commits into from
Jan 16, 2026
+9 −0
Merged

chore: Add gcp resource name span attribute #4306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98275f5
chore: Add gcp resource name span attribute
surbhigarg92 Jan 16, 2026
61c33e3
Update google-cloud-spanner/src/test/java/com/google/cloud/spanner/Op…
surbhigarg92 Jan 16, 2026
1380eb7
chore: Add gcp resource name span attribute
surbhigarg92 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/TraceWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ class TraceWrapper {
AttributeKey.stringKey("gcp.client.version");
private static final AttributeKey<String> GCP_CLIENT_REPO_KEY =
AttributeKey.stringKey("gcp.client.repo");
private static final AttributeKey<String> GCP_RESOURCE_NAME_KEY =
AttributeKey.stringKey("gcp.resource.name");
private static final String GCP_RESOURCE_NAME_PREFIX = "//spanner.googleapis.com/";
private static final AttributeKey<String> THREAD_NAME_KEY = AttributeKey.stringKey("thread.name");

private final Tracer openCensusTracer;
Expand Down Expand Up @@ -219,6 +222,7 @@ Attributes createDatabaseAttributes(DatabaseId db) {
AttributesBuilder builder = Attributes.builder();
builder.put(DB_NAME_KEY, db.getDatabase());
builder.put(INSTANCE_NAME_KEY, db.getInstanceId().getInstance());
builder.put(GCP_RESOURCE_NAME_KEY, GCP_RESOURCE_NAME_PREFIX + db.getName());
return builder.build();
}

Expand Down
5 changes: 5 additions & 0 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/OpenTelemetrySpanTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,6 +912,11 @@ private static void verifyCommonAttributes(SpanData span) {
assertEquals(
span.getAttributes().get(AttributeKey.stringKey("gcp.client.version")),
GaxProperties.getLibraryVersion(TraceWrapper.class));
assertEquals(
span.getAttributes().get(AttributeKey.stringKey("gcp.resource.name")),
String.format(
"//spanner.googleapis.com/projects/%s/instances/%s/databases/%s",
TEST_PROJECT, TEST_INSTANCE, TEST_DATABASE));
}

private static void verifyTableAttributes(SpanData span) {
Expand Down
Loading