Skip to content

test: skip PGErrorCode assert check for experimental host in ITQueryTest.badquery #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahul2393 merged 2 commits into from
Jan 12, 2026
Merged

test: skip PGErrorCode assert check for experimental host in ITQueryTest.badquery #4290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02f4192
test: skip PGErrorCode assert check for experimental host
sagnghos Jan 7, 2026
23b29bd
gemini suggested code applied
sagnghos Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package com.google.cloud.spanner.it;

import static com.google.cloud.spanner.testing.EmulatorSpannerHelper.isUsingEmulator;
import static com.google.cloud.spanner.testing.ExperimentalHostHelper.isExperimentalHost;
import static com.google.common.base.Strings.isNullOrEmpty;
import static com.google.common.truth.Truth.assertThat;
import static java.util.Arrays.asList;
Expand Down Expand Up @@ -143,6 +144,9 @@ public void badQuery() {
exception.getMessage().contains("column \"apples\" does not exist"));
// See https://www.postgresql.org/docs/current/errcodes-appendix.html
// '42703' == undefined_column
assumeFalse(
"Skipping PGErrorCode check on experimental host due to b/473270453",
isExperimentalHost());
assertEquals("42703", exception.getPostgreSQLErrorCode());
} else {
assertTrue(
Expand Down
Loading