Skip to content

test: Wrap createTestAuthorizedView with retries #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trollyxia wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: Wrap createTestAuthorizedView with retries #2789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40ccae4
test: Wrap createTestAuthorizedView with retries
trollyxia Feb 18, 2026
abcd9a7
Merge branch 'main' into it
mutianf Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/ReadIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@

@RunWith(JUnit4.class)
public class ReadIT {

private String prefix;

@ClassRule public static TestEnvRule testEnvRule = new TestEnvRule();
Expand Down Expand Up @@ -460,7 +461,7 @@ public void rangeQueries() {
}

@Test
public void rangeQueriesOnAuthorizedView() {
public void rangeQueriesOnAuthorizedView() throws InterruptedException {
assume()
.withMessage("AuthorizedView is not supported on Emulator")
.that(testEnvRule.env())
Expand Down Expand Up @@ -761,6 +762,7 @@ public void onSuccess(Row result) {
}

static class AccumulatingObserver implements ResponseObserver<Row> {

final List<Row> responses = Lists.newArrayList();
final SettableApiFuture<Void> completionFuture = SettableApiFuture.create();

Expand Down
31 changes: 29 additions & 2 deletions ...able/src/test/java/com/google/cloud/bigtable/misc_utilities/AuthorizedViewTestHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,26 @@

package com.google.cloud.bigtable.misc_utilities;

import com.google.api.gax.rpc.UnavailableException;
import com.google.cloud.bigtable.admin.v2.models.AuthorizedView;
import com.google.cloud.bigtable.admin.v2.models.CreateAuthorizedViewRequest;
import com.google.cloud.bigtable.admin.v2.models.FamilySubsets;
import com.google.cloud.bigtable.admin.v2.models.SubsetView;
import com.google.cloud.bigtable.test_helpers.env.TestEnvRule;
import java.time.Duration;
import java.util.UUID;
import java.util.logging.Level;
import java.util.logging.Logger;

public class AuthorizedViewTestHelper {

public static String AUTHORIZED_VIEW_ROW_PREFIX = "row#";
public static String AUTHORIZED_VIEW_COLUMN_QUALIFIER = "qualifier";

public static AuthorizedView createTestAuthorizedView(TestEnvRule testEnvRule) {
private static final Logger logger = Logger.getLogger(AuthorizedViewTestHelper.class.getName());

public static AuthorizedView createTestAuthorizedView(TestEnvRule testEnvRule)
throws InterruptedException {
String tableId = testEnvRule.env().getTableId();
String authorizedViewId = UUID.randomUUID().toString();
CreateAuthorizedViewRequest request =
Expand All @@ -40,6 +48,25 @@ public static AuthorizedView createTestAuthorizedView(TestEnvRule testEnvRule) {
FamilySubsets.create()
.addQualifierPrefix(AUTHORIZED_VIEW_COLUMN_QUALIFIER)))
.setDeletionProtection(false);
return testEnvRule.env().getTableAdminClient().createAuthorizedView(request);
int retryCount = 0;
int maxRetries = 10;
while (true) {
try {
return testEnvRule.env().getTableAdminClient().createAuthorizedView(request);
} catch (UnavailableException e) {
if (++retryCount == maxRetries) {
throw e;
}
logger.log(
Level.INFO,
"Retrying createAuthorizedView "
+ authorizedViewId
+ " in table "
+ tableId
+ ", retryCount: "
+ retryCount);
Thread.sleep(Duration.ofMinutes(1).toMillis());
Copy link
Contributor

@igorbernstein2 igorbernstein2 Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minute seems heavy handed, how about exponential backoff?

// exponential backoff delay starting at 100ms
int expSleep = 100 * Math.pow(2, retryCount);
Thread.sleep(Math.min(expSleep, TimeUnit.MINUTES.toMillis(1));
``

}
}
}
}
Loading