Conversation
product-auto-label
bot
added
size: m
vchudnov-g
previously approved these changes
Nov 10, 2025
| @@ -0,0 +1,10 @@ | |||
| image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 | |||
There was a problem hiding this comment.
When should we update this SHA? How? Maybe include a comment here or in a README.
Contributor
Author
There was a problem hiding this comment.
The only reason to update the SHA is when there is a specific feature or fix which is only available in a newer image. This is similar to any dependency update. In this case, this SHA is the first version of the python-librarian-generator to support librarian version 1.0.0 which was just released. https://github.com/googleapis/librarian/releases/tag/v1.0.0
Use the instructions here to update the SHA: https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#pin-the-language-container-version-in-stateyaml
librarian update-image -image=us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
parthea
force-pushed
the
onboard-librarian
branch
from
540e750 to
afcc58d
Compare
ohmayr
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards googleapis/librarian#2454
Blocked on #485