refactor(pubsub)!: Rename Client to BasePublisher #4283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4283 +/- ##
=======================================
Coverage 94.80% 94.80%
=======================================
Files 187 187
Lines 7194 7194
=======================================
Hits 6820 6820
Misses 374 374 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
previously approved these changes
Jan 15, 2026
Collaborator
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
SGTM. I think we can bikeshed the names once we are closer to "not preview".
suzmue
changed the title
suzmue
force-pushed
the
feat/pubsub-rename-client-to-basepublisher
branch
from
8b6fa00 to
e0c5b02
Compare
dbolduc
approved these changes
Jan 21, 2026
Member
dbolduc
left a comment
dbolduc
left a comment
There was a problem hiding this comment.
refactor(pubsub)!: ... ?
I think we would include this change in our release notes.
Collaborator
Author
Right it is released. Updated. |
suzmue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in simplifying the Publisher client creation and renames the Client and associated builders.
For #4282