feat: regenerate google-cloud-b packages#17090
Conversation
This Pull Request drops support for Python <=3.9 in generated packages. This is part of our ongoing effort to modernize the Cloud Python SDK libraries and remove support for End-of-Life (EOL) Python versions. - Removed Python <=3.9 from testing, configuration, and constraints files. - Resolved dependency conflicts arising from dropping Python <=3.9 support. - Cleaned up obsolete code related to Python <=3.9 support. - Updated select copyright dates - Updated some autogenerated headings - Updated some tests to resolve issues discovered during this migration.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Google Cloud Python client libraries to drop support for Python 3.9, establishing Python 3.10 as the new minimum version. Key changes include updating copyright headers to 2026, bumping dependency lower bounds in setup.py, and refactoring asynchronous samples to properly use await for client calls. Unit tests have been streamlined by removing legacy compatibility code. Review feedback points out that essential dependencies are missing from the new constraints files for bigquery-storage and build, and recommends restoring the -W flag in the backupdr documentation build to ensure warnings are treated as errors.
| google-auth==2.14.1 | ||
| grpcio==1.44.0 | ||
| proto-plus==1.22.3 | ||
| protobuf==4.25.8 |
There was a problem hiding this comment.
Several dependencies essential for google-cloud-bigquery-storage (and previously present in constraints-3.9.txt) are missing from this updated constraints file. These include fastavro, pandas, pyarrow, and libcst. According to the project rules, all library dependencies and extras should be listed in the constraints file, pinned to their lower bounds as specified in setup.py.
protobuf==4.25.8
fastavro==1.1.0
pandas==1.1.3
pyarrow==3.0.0
libcst==0.2.5
| @@ -390,7 +389,6 @@ def docs(session): | |||
| shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True) | |||
| session.run( | |||
| "sphinx-build", | |||
There was a problem hiding this comment.
The -W flag has been removed from the sphinx-build command. This flag is important for maintaining documentation quality as it treats warnings as errors, preventing issues like broken links or malformed docstrings from being merged. It should be restored to ensure CI catches documentation regressions.
| "sphinx-build", | |
| "sphinx-build", | |
| "-W", # warnings as errors |
| google-auth==2.14.1 | ||
| grpcio==1.44.0 | ||
| proto-plus==1.22.3 | ||
| protobuf==4.25.8 |
There was a problem hiding this comment.
The grpc-google-iam-v1 dependency is missing from this constraints file, although it is listed in setup.py with a lower bound of 0.12.4. It should be included here to ensure correct lower-bound testing for this package.
protobuf==4.25.8
grpc-google-iam-v1==0.12.4
1 participant
This Pull Request drops support for Python <=3.9 in generated packages. This is part of our ongoing effort to modernize the Cloud Python SDK libraries and remove support for End-of-Life (EOL) Python versions.