feat(spanner): log client configuration at startup#17040
Draft
sinhasubham wants to merge 1 commit into
Draft
Conversation
sinhasubham
force-pushed
the
client_config
branch
from
727fa09 to
cbe95d4
Compare
sinhasubham
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces pickle with json in partition_helper.py to improve security and introduces a feature to log Spanner client options via an environment variable. Review feedback recommends internalizing the host attribute to _host to avoid naming conflicts and suggests using public properties instead of private attributes for logging to improve consistency.
sinhasubham
force-pushed
the
client_config
branch
from
cbe95d4 to
b1b0263
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an already reviewed change as part of this PR in old repo.
This change introduces logging for Spanner client options upon initialization.
This allows customers to easily capture and inspect the configuration being used, which is valuable for debugging and verification.
This feature mirrors the existing logSpannerOptions functionality in the Java client, improving consistency across client libraries. googleapis/java-spanner#4141