chore(librarian): update configuration for google-cloud-firestore#16024
chore(librarian): update configuration for google-cloud-firestore#16024
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue in the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a critical issue where the google-cloud-firestore package was incorrectly named google-cloud-firestore-admin due to the processing order of API paths during generation. By reordering the apis list in .librarian/state.yaml to place google/firestore/v1 last, the change ensures that the correct package name takes precedence. This is a targeted and effective fix for the described problem, resolving the generation failure.
Generation for
google-cloud-firestorefailed in #16023 because of failed check that was added in #14441. The library had an incorrect distribution name insetup.py. The generation process for google-cloud-python packages with multiple API versions/sub-packages relies on the order of entries in the apis list. Since each API path generates a setup.py and the last one processed takes precedence, the previous ordering caused the package to be incorrectly named google-cloud-firestore-admin instead of the expected google-cloud-firestore.This PR moves google/firestore/v1 to the bottom of the apis list, resulting in the correct package name in the generated setup.py.
See related issue googleapis/librarian#4205