Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/presubmit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
- uses: pnpm/action-setup@v4
with:
version: ^10.0.0
- uses: oven-sh/setup-bun@v2
- run: node --version
- run: ci/run_conditional_tests.sh
name: Run unit tests
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/windows-presubmit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,28 @@ jobs:
- uses: actions/checkout@v6
with:
fetch-depth: 300
- name: Update Windows path to use Linux/MacOS compatible binaries from Git Bash
run: echo "C:\Program Files\Git\usr\bin" >> $GITHUB_PATH
shell: bash
- name: Check which cp is being used
run: where cp
run: echo %PATH%
shell: cmd
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v6
with:
node-version: ${{ matrix.node-version }}
- uses: pnpm/action-setup@v4
with:
version: ^10.0.0
- uses: oven-sh/setup-bun@v2
- run: node --version
- run: bash ci/run_conditional_tests.sh
name: Run windows unit tests
shell: bash
env:
BUILD_TYPE: presubmit
TEST_TYPE: units
SHELL: C:\Program Files\Git\bin\bash.exe
npm_config_script_shell: bash

10 changes: 5 additions & 5 deletions ci/run_conditional_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ set -e
if [[ "${changed}" -eq 0 ]]; then
echo "no change detected in ci"
else
echo "skipping trigger of tests for now: tracking in #7540"
# echo "change detected in ci, we should test everything"
# echo "result of git diff ${GIT_DIFF_ARG} ci:"
# git diff ${GIT_DIFF_ARG} ci
# GIT_DIFF_ARG=""
#echo "skipping trigger of tests for now: tracking in #7540"
echo "change detected in ci, we should test everything"
echo "result of git diff ${GIT_DIFF_ARG} ci:"
git diff ${GIT_DIFF_ARG} ci
GIT_DIFF_ARG=""
fi

# Now we have a fixed list, but we can change it to autodetect if
Expand Down
9 changes: 7 additions & 2 deletions ci/run_single_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,13 @@ if [ ${BUILD_TYPE} != "presubmit" ]; then
fi

# Install dependencies
echo "pnpm install --ignore-scripts --engine-strict --prod; pnpm install"
pnpm install --ignore-scripts --engine-strict --prod; pnpm install
#
# The filter is needed to prevent bun from installing all packages in the repo
# from the root. By default it prefers to analyze, install, and at the root
# so dependencies can be deduplicated. We will try that in a separate PR for
# comparison.
echo "bun install --ignore-scripts --prod --filter .; bun install --filter ."
bun install --ignore-scripts --prod --filter . ; bun install --filter .


retval=0
Expand Down
Loading