fix: use compatible syncpack configuration#926
fix: use compatible syncpack configuration#926JamieMason wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
The syncpack errors are genuine according to the current configuration, which is asking that dependencies be on the same MAJOR.MINOR but any PATCH:
Others like I don't have enough knowledge about what policies you would want to use to be able to help much further, sorry. There is a getting started guide at https://syncpack.dev/ and docs on the different policies available at https://syncpack.dev/version-groups/. |
|
/gcbrun |
Fixes #923
.github/workflows/syncpack.yamlto use the same major version as package.json"sameMinorNew": trueconfig (does not exist in syncpack)The below line of
.github/workflows/syncpack.yamlinstalled the latest major version unconstrained, and a major semver breaking change update had been released since the time of writing.google-cloud-node-core/.github/workflows/syncpack.yaml
Line 18 in 7feb4c8
I hope this helps, thanks for trying syncpack.
/cc @sofisl