Skip to content

fix: use compatible syncpack configuration#926

Open
JamieMason wants to merge 1 commit intogoogleapis:mainfrom
JamieMason:main
Open

fix: use compatible syncpack configuration#926
JamieMason wants to merge 1 commit intogoogleapis:mainfrom
JamieMason:main

Conversation

@JamieMason
Copy link

@JamieMason JamieMason commented Mar 7, 2026

Fixes #923

  • Update .github/workflows/syncpack.yaml to use the same major version as package.json
  • Removes "sameMinorNew": true config (does not exist in syncpack)
  • Migrate config and commands to v14 (https://syncpack.dev/guide/migrate-v14/)

The below line of .github/workflows/syncpack.yaml installed the latest major version unconstrained, and a major semver breaking change update had been released since the time of writing.

- run: npm install -g syncpack

I hope this helps, thanks for trying syncpack.

/cc @sofisl

@JamieMason JamieMason requested a review from a team as a code owner March 7, 2026 15:22
@google-cla
Copy link

google-cla bot commented Mar 7, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@JamieMason
Copy link
Author

The syncpack errors are genuine according to the current configuration, which is asking that dependencies be on the same MAJOR.MINOR but any PATCH:

protobufjs for example is used on 7.5 and 7.0

   5x protobufjs
      ✘ ^7.5.4 in packages/gax/package.json at .dependencies (SameMinorMismatch)
      ✘ ^7.5.4 in packages/nodejs-proto-files/package.json at .dependencies (SameMinorMismatch)
      ✘ ^7.5.4 in packages/proto3-json-serializer-nodejs/package.json at .dependencies (SameMinorMismatch)
      ✘ ^7.0.0 in packages/proto3-json-serializer-nodejs/samples/package.json at .dependencies (SameMinorMismatch)
      ✘ ^7.0.0 in packages/gax/test/test-application/package.json at .dependencies (SameMinorMismatch)

Others like puppeteer are flagged because a range of ^ would allow MINOR versions other than 24.0 to be installed.

   1x puppeteer
      ✘ ^24.0.0 → ~24.0.0 in packages/google-auth-library-nodejs/samples/puppeteer/package.json at .dependencies (SameMinorOverridesSemverRange)

I don't have enough knowledge about what policies you would want to use to be able to help much further, sorry. There is a getting started guide at https://syncpack.dev/ and docs on the different policies available at https://syncpack.dev/version-groups/.

@sofisl
Copy link
Contributor

sofisl commented Mar 9, 2026

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

syncpack was failing without logs

2 participants