fix(bqjdbc): fallback to RestAPI if ReadAPI is not accessible#13018
Open
fix(bqjdbc): fallback to RestAPI if ReadAPI is not accessible#13018
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a fallback mechanism in BigQueryStatement that reverts to the Standard JSON API if the Read API fails due to a permission denied error. It also includes logging enhancements and unit tests for the new logic. Feedback focuses on expanding the exception check to include ApiException and using an iterative approach to traverse exception chains. Additionally, a compilation error in the test suite regarding a missing class prefix for assertEquals needs to be addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/506217300
ReadAPI requires separate set of permissions, if authenticated user has no access to use it, fallback to a regular paginated API instead of returning an error.
Added info-level log with job/query ID and result row #.