test(bigquery): Fix flaky ITBigQueryTest#testOpenTelemetryTracingQuery#12769
Merged
jinseopkim0 merged 5 commits intomainfrom Apr 14, 2026
Merged
test(bigquery): Fix flaky ITBigQueryTest#testOpenTelemetryTracingQuery#12769jinseopkim0 merged 5 commits intomainfrom
jinseopkim0 merged 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the testOpenTelemetryTracingQuery integration test to handle cases where BigQuery creates a job despite the JOB_CREATION_OPTIONAL setting. The review feedback correctly identifies that the original assertion for a null job ID was lost for the standard case and suggests adding an else block to maintain that validation.
...igquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
lqiu96
reviewed
Apr 13, 2026
...igquery/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Outdated
Show resolved
Hide resolved
lqiu96
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/467063732