Skip to content

feat(Log4Net)!: Support credential type configuration#15271

Merged
robertvoinescu-work merged 1 commit intogoogleapis:mainfrom
robertvoinescu-work:log4net/windy-eagle
Jan 28, 2026
Merged

feat(Log4Net)!: Support credential type configuration#15271
robertvoinescu-work merged 1 commit intogoogleapis:mainfrom
robertvoinescu-work:log4net/windy-eagle

Conversation

@robertvoinescu-work
Copy link
Copy Markdown
Contributor

@robertvoinescu-work robertvoinescu-work commented Nov 21, 2025

Added CredentialType to GoogleStackdriverAppender configuration to support credential specification.

BREAKING CHANGE: Credentials now default to service_account type instead of auto-detecting. If using
non-service-account credentials (e.g., authorized_user), you MUST explicitly set the CredentialType
property in your configuration.

@robertvoinescu-work robertvoinescu-work changed the title feat: Add credential type parameter support to Log4Net. feat: Add credential type parameter support to Log4Net Nov 21, 2025
@robertvoinescu-work robertvoinescu-work force-pushed the log4net/windy-eagle branch 6 times, most recently from 640a2e1 to 51daac6 Compare November 21, 2025 18:18
@robertvoinescu-work robertvoinescu-work marked this pull request as ready for review November 21, 2025 18:30
@robertvoinescu-work robertvoinescu-work requested a review from a team November 21, 2025 18:30
@amanda-tarafa amanda-tarafa marked this pull request as draft November 21, 2025 21:06
@amanda-tarafa amanda-tarafa added do-not-merge do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do-not-merge labels Nov 21, 2025
@robertvoinescu-work robertvoinescu-work marked this pull request as ready for review November 21, 2025 23:14
@amanda-tarafa amanda-tarafa added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 3, 2025
Copy link
Copy Markdown
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mostly the same questions here regarding the defaults. I know what you've done in code, but I want to make sure that what's done in configuration files is fine as well. Let's chat about it.

@robertvoinescu-work robertvoinescu-work changed the title feat: Add credential type parameter support to Log4Net feat: Support credential type parameter for Log4Net Dec 19, 2025
Copy link
Copy Markdown
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things, but mostly questions. Can you update the documentation as well? Here: https://github.com/googleapis/google-cloud-dotnet/blob/main/apis/Google.Cloud.Logging.Log4Net/docs/configuration.md

Also, apply the relevant changes from this one to the NLog PR, once we get this one merged and all relevant changes done in NLog, I'll review that one. Thanks.

Comment thread generator-input/apis.json
@robertvoinescu-work robertvoinescu-work force-pushed the log4net/windy-eagle branch 3 times, most recently from 5a19d2f to f119390 Compare January 14, 2026 00:09
Copy link
Copy Markdown
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor things, it looks good.

Comment thread generator-input/apis.json Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding the extra line again.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .editorconfig specifies adding a new line at the end of each file:
image

My editor must have picked it up and added it in. I might prefer to keep the new line so it's in line with the config, but I can also see a preferences for not introducing these formatting updates into older files. What would you prefer?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the new line for now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing is apis.json is generated. I don't mind changing what generates it to add the extra blank line, but until we do that, it will be removed even if we add it.

Comment thread apis/Google.Cloud.Logging.Log4Net/docs/configuration.md Outdated
@amanda-tarafa amanda-tarafa removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 26, 2026
Adds support for credential type and refactors integration tests to unit tests.
@robertvoinescu-work robertvoinescu-work merged commit 4d784bb into googleapis:main Jan 28, 2026
12 checks passed
@robertvoinescu-work robertvoinescu-work changed the title feat: Support credential type parameter for Log4Net feat(Log4Net)!: Support credential type configuration Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants