feat(storage): add support for bucket ip filter#15250
feat(storage): add support for bucket ip filter#15250ddelgrosso1 wants to merge 12 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: storage
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15250 +/- ##
========================================
Coverage 92.95% 92.95%
========================================
Files 2448 2450 +2
Lines 226468 226930 +462
========================================
+ Hits 210514 210949 +435
- Misses 15954 15981 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return Status{}; | ||
| } | ||
|
|
||
| Status ParseIpFilter(BucketMetadata& meta, nlohmann::json const& json) { |
There was a problem hiding this comment.
This code can be made more readable by using from_json semantics.
There was a problem hiding this comment.
Going to leave this for the time being as it follows the coding patterns in the rest of the file. Longer term we may want to refactor to use to/from_json.
| json["iamConfiguration"] = std::move(value); | ||
| } | ||
|
|
||
| void ToJsonIpFilter(nlohmann::json& json, BucketMetadata const& meta) { |
There was a problem hiding this comment.
Ditto, to_json semantics seems to be potential candidate here.
There was a problem hiding this comment.
Going to leave this for the time being as it follows the coding patterns in the rest of the file. Longer term we may want to refactor to use to/from_json.
| } | ||
|
|
||
| Status PatchIpFilter(Bucket& b, nlohmann::json const& p) { | ||
| if (p.is_null()) { |
There was a problem hiding this comment.
Going to leave this for the time being as it follows the coding patterns in the rest of the file. Longer term we may want to refactor to use to/from_json.
ddelgrosso1
force-pushed
the
bucket-ip-filter
branch
from
1d58a67 to
20e6563
Compare
ddelgrosso1
force-pushed
the
bucket-ip-filter
branch
from
20e6563 to
8c3d624
Compare
ddelgrosso1
force-pushed
the
bucket-ip-filter
branch
from
8c3d624 to
7b8b0e3
Compare
ddelgrosso1
had a problem deploying
to
external
GitHub Actions
Failure
3 participants
This change is