-
Notifications
You must be signed in to change notification settings - Fork 13
feat: InterleaveIn for indexes #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Google Cloud Spanner Entity Framework Core provider by adding comprehensive support for interleaved indexes. It provides developers with a new fluent API to define these indexes in their models, ensures that the generated migration scripts include the appropriate Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for INTERLEAVE IN on indexes, a Cloud Spanner feature. The changes include a new fluent API extension method InterleaveIn for IndexBuilder, updates to the migration SQL generator to produce the correct DDL, and modifications to the scaffolding logic to recognize interleaved indexes from an existing database. The implementation looks solid, but I have a few suggestions to improve robustness and maintainability, particularly regarding migrations on scaffolded models.
Google.Cloud.EntityFrameworkCore.Spanner/Migrations/SpannerMigrationsSqlGenerator.cs
Show resolved
Hide resolved
Google.Cloud.EntityFrameworkCore.Spanner/Extensions/InterleaveInParentExtension.cs
Show resolved
Hide resolved
Google.Cloud.EntityFrameworkCore.Spanner/Metadata/SpannerAnnotationNames.cs
Outdated
Show resolved
Hide resolved
Add annotations for INTERLEAVE IN for indexes. Fixes #634
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for interleaved indexes in Entity Framework Core for Spanner. The changes are comprehensive, covering code-first configuration, DDL generation, and database-first scaffolding. The implementation looks solid. I have one suggestion to improve the robustness of the DDL generation logic.
Add annotations for INTERLEAVE IN for indexes.
Fixes #634