Skip to content

Conversation

@olavloite
Copy link
Collaborator

Add annotations for INTERLEAVE IN for indexes.

Fixes #634

@gemini-code-assist
Copy link

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Google Cloud Spanner Entity Framework Core provider by adding comprehensive support for interleaved indexes. It provides developers with a new fluent API to define these indexes in their models, ensures that the generated migration scripts include the appropriate INTERLEAVE IN clauses, and enables the reverse engineering of existing interleaved indexes from a Spanner database. This feature is crucial for optimizing query performance in Spanner by physically co-locating related data.

Highlights

  • New API for Interleaved Indexes: Introduced a new InterleaveIn extension method for IndexBuilder in Entity Framework Core, allowing developers to fluently define indexes that are interleaved within a parent table in Google Cloud Spanner.
  • SQL Generation for Interleaved Indexes: Implemented logic within the Spanner migrations SQL generator to correctly produce CREATE INDEX ... INTERLEAVE IN <ParentTableName> statements based on the new InterleaveIn annotation.
  • Reverse Engineering Support: Added functionality to the database model factory to read PARENT_TABLE_NAME from Spanner's INFORMATION_SCHEMA and apply the InterleaveIn annotation, enabling the reverse engineering (scaffolding) of existing interleaved indexes.
  • Annotation Definition and Propagation: Defined a new Spanner:InterleaveIn annotation constant and ensured its proper propagation through the relational annotation provider for index metadata.
  • Migration Test Coverage: Included new test cases to verify the correct generation of migration scripts for interleaved indexes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for INTERLEAVE IN on indexes, a Cloud Spanner feature. The changes include a new fluent API extension method InterleaveIn for IndexBuilder, updates to the migration SQL generator to produce the correct DDL, and modifications to the scaffolding logic to recognize interleaved indexes from an existing database. The implementation looks solid, but I have a few suggestions to improve robustness and maintainability, particularly regarding migrations on scaffolded models.

Add annotations for INTERLEAVE IN for indexes.

Fixes #634
@olavloite
Copy link
Collaborator Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for interleaved indexes in Entity Framework Core for Spanner. The changes are comprehensive, covering code-first configuration, DDL generation, and database-first scaffolding. The implementation looks solid. I have one suggestion to improve the robustness of the DDL generation logic.

@olavloite olavloite requested a review from bhatt4982 January 26, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrations: support interleaved indexes

1 participant