Skip to content

[hermes] Use prebuilt Aeneas Lean artifacts#3229

Closed
joshlf wants to merge 1 commit intomainfrom
Gzi3vyc4cu7ln7covbdhksi66puulql2i
Closed

[hermes] Use prebuilt Aeneas Lean artifacts#3229
joshlf wants to merge 1 commit intomainfrom
Gzi3vyc4cu7ln7covbdhksi66puulql2i

Conversation

@joshlf
Copy link
Copy Markdown
Member

@joshlf joshlf commented Apr 8, 2026

Previously, we generated Lean which took a dependency on the Aeneas Lean
library from GitHub. Now that we ship prebuilts which include this
library, and now that we install it via cargo hermes setup, we can
take a local dependency instead. This reduces the risk of network
flakiness and makes certain workflows more cacheable, especially in
development on Hermes and in CI.


Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v1 Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gzi3vyc4cu7ln7covbdhksi66puulql2i && git checkout -b pr-Gzi3vyc4cu7ln7covbdhksi66puulql2i FETCH_HEAD

Checkout

git fetch origin refs/heads/Gzi3vyc4cu7ln7covbdhksi66puulql2i && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gzi3vyc4cu7ln7covbdhksi66puulql2i && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gzi3vyc4cu7ln7covbdhksi66puulql2i

Stacked PRs enabled by GHerrit.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.88%. Comparing base (4c26da0) to head (a918be8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3229   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files          20       20           
  Lines        6076     6076           
=======================================
  Hits         5583     5583           
  Misses        493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Previously, we generated Lean which took a dependency on the Aeneas Lean
library from GitHub. Now that we ship prebuilts which include this
library, and now that we install it via `cargo hermes setup`, we can
take a local dependency instead. This reduces the risk of network
flakiness and makes certain workflows more cacheable, especially in
development *on* Hermes and in CI.

gherrit-pr-id: Gzi3vyc4cu7ln7covbdhksi66puulql2i
@joshlf joshlf force-pushed the Gzi3vyc4cu7ln7covbdhksi66puulql2i branch from 5952c2d to a918be8 Compare April 8, 2026 18:21
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Optimistically Approved: Changes appear scoped. Final strict verification will occur in the Merge Queue.

@joshlf joshlf enabled auto-merge April 8, 2026 18:32
@joshlf
Copy link
Copy Markdown
Member Author

joshlf commented Apr 9, 2026

Squashed into #3232

@joshlf joshlf closed this Apr 9, 2026
auto-merge was automatically disabled April 9, 2026 01:43

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants