-
Notifications
You must be signed in to change notification settings - Fork 138
[derive] Document use of Field trait
#2865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Originally introduced in #2127, this trait is used to ensure that field types which mention `Self` resolve correctly (always to the original type, and never to generated utility types). gherrit-pr-id: Gf808298c8219fddf1b406e7bb4357a4f3bb40b82
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the internal documentation of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation in the form of code comments to explain the use of the Field trait within the KnownLayout derive macro. The added comments clearly explain that the Field trait is used to solve Self hygiene issues in proc-macros, ensuring that Self in field types correctly refers to the original type being derived on, rather than any generated helper types. The changes are accurate, well-explained, and significantly improve the maintainability of this complex macro code. This is a great improvement, and I have no further suggestions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2865 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 20 20
Lines 5824 5824
=======================================
Hits 5355 5355
Misses 469 469 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Originally introduced in #2127, this trait is used to ensure that field
types which mention
Selfresolve correctly (always to the originaltype, and never to generated utility types).
Fieldtrait #2865