[Breaking] Replace usages of dart:math geometry types with custom types#316
Open
parlough wants to merge 7 commits intogoogle:masterfrom
Open
[Breaking] Replace usages of dart:math geometry types with custom types#316parlough wants to merge 7 commits intogoogle:masterfrom
dart:math geometry types with custom types#316parlough wants to merge 7 commits intogoogle:masterfrom
Conversation
Contributor
|
I don't know that I have enough context on the 'why' to evaluate this PR. Perhaps we should resolve dart-lang/sdk#54852 first? cc @kevmoo for thoughts |
Contributor
Author
That issue is the why for this. This package seems to be the only dependency of Flutter that uses these types, being a blocking stop in deprecating the types. Also, Happy to continue the discussion in that issue first though :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change and shouldn't be included until the next major release.
These types were built for
dart:html, contain unrelated functionality, and require this library to always add anintgeneric. To aid the deprecation of these types indart:math, migrate this package to custom types. These types, particularly the addition of a newSizetype can more semantically match their purpose in the package, and be a bit simpler to use, no longer having a type parameter.Contributes to dart-lang/sdk#54852