feat: update ConversionOutcome to output as string in JSON#5044
Merged
jess-lowe merged 4 commits intogoogle:masterfrom Mar 17, 2026
Merged
Conversation
This implements the json.Marshaler and json.Unmarshaler interfaces for the `ConversionOutcome` enum so that the `outcome` field in the `ConversionMetrics` output shows the string value (e.g. "Successful") instead of its integer value. Co-authored-by: jess-lowe <86962800+jess-lowe@users.noreply.github.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This implements the json.Marshaler and json.Unmarshaler interfaces for the `ConversionOutcome` enum so that the `outcome` field in the `ConversionMetrics` output shows the string value (e.g. "Successful") instead of its integer value. The receivers were correctly adjusted to use value receivers for String() and MarshalJSON(), and pointer receiver for UnmarshalJSON(), which fixes the `recvcheck` linter error by silencing it on the UnmarshalJSON method. Blank lines were also added to adhere to `nlreturn` rules. Co-authored-by: jess-lowe <86962800+jess-lowe@users.noreply.github.com>
another-rex
approved these changes
Mar 17, 2026
jess-lowe
added
the
await release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the json.Marshaler and json.Unmarshaler interfaces for the
ConversionOutcomeenum so that theoutcomefield in theConversionMetricsoutput shows the string value (e.g. "Successful") instead of its integer value.This makes it easier to read what caused a failure in the metrics output