fix(vulnfeeds): ignore empty reference URLs in nvd conversion#5013
Open
jess-lowe wants to merge 1 commit intogoogle:masterfrom
Open
fix(vulnfeeds): ignore empty reference URLs in nvd conversion#5013jess-lowe wants to merge 1 commit intogoogle:masterfrom
jess-lowe wants to merge 1 commit intogoogle:masterfrom
Conversation
Update `ClassifyReferences` in `vulnfeeds/vulns/vulns.go` to explicitly skip references that have a blank/empty URL before categorizing them. This prevents the output from containing blank reference objects that lack a valid URL. Also added a test case in `vulns_test.go` to verify this behavior. Co-authored-by: jess-lowe <86962800+jess-lowe@users.noreply.github.com>
another-rex
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
ClassifyReferencesinvulnfeeds/vulns/vulns.goto explicitly skip references that have a blank/empty URL before categorizing them. This prevents the output from containing blank reference objects that lack a valid URL. Also added a test case invulns_test.goto verify this behavior.