Open
Conversation
Contributor
Author
|
@bocops , @fulldecent (and anyone else) would appreciate comments before committing. |
bocops
suggested changes
May 2, 2025
Contributor
bocops
left a comment
bocops
left a comment
There was a problem hiding this comment.
Maximum values in encoding should reflect the multiplication with a large constant before.
bocops
approved these changes
May 2, 2025
Contributor
|
Great to see updates to the spec are in scope. Please give me a little more time I'd like to get through all this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #718
This updates the specification to include both the reverse and forward encoding algorithms.
Most implementations currently use the reverse algorithm, but the forward one might be slightly more efficient since it only ever needs to compute the requested number of digits. (The existing reverse approach must calculate all 15 digits if 11 or more digits are requested, or at least 10 regardless of what is requested.)
There are some minor changes due to formatting the markdown with the Prettier VSCode extension.