feat: add China Broadnet (中国广电) 1610 mobile number support #3970
Open
ninjachen wants to merge 1 commit intogoogle:masterfrom
Open
feat: add China Broadnet (中国广电) 1610 mobile number support #3970ninjachen wants to merge 1 commit intogoogle:masterfrom
ninjachen wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
33207e2 to
c89cd7f
Compare
c89cd7f to
b520b84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Summary
1610number prefix as a valid mobile number pattern for China Broadnet (中国广电)en,zh, andzh_HantlocalesBackground
China Broadnet (中国广电) is China's fourth telecom operator. The
192prefix is already supported, but the1610prefix was missing from libphonenumber metadata. Here is the wiki pageChanges
resources/PhoneNumberMetadata.xml— add1610\d{7}to CN mobile patternresources/carrier/en/86.txt— add861610|China Broadnetresources/carrier/zh/86.txt— add861610|中国广电resources/carrier/zh_Hant/86.txt— add861610|中國廣電ExampleNumbersTest.java— add testtestChinaBroadnet1610IsValidMobileTest plan
testChinaBroadnet1610IsValidMobilevalidates parsing and type detection