Deprecated carrier and timezone mapper in favour of variants in their corresponding packages#3773
Open
tvislavski wants to merge 8 commits into
Open
Deprecated carrier and timezone mapper in favour of variants in their corresponding packages#3773tvislavski wants to merge 8 commits into
tvislavski wants to merge 8 commits into
Conversation
…hese modules belong to the same package as core libphonenumber library, which leads to the split package problem with Java modules.
…omatic-module-names # Conflicts: # java/carrier/pom.xml # java/geocoder/pom.xml
… corresponding packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic is intact, but the existing classes are deprecated and delegate to the new ones that reside in their corresponding packages.
This is the first step towards dealing with the problem of split packages (geocoder and carrier are released as separate jars, but they contain classes belonging to the same package as those in libphonenumber jar).