Strip extension before appending formatted extension. #3724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvislavski
previously approved these changes
Nov 21, 2024
Member
|
Please update pending_code_changes.txt |
tvislavski
previously approved these changes
Dec 3, 2024
mandlil
previously approved these changes
Dec 3, 2024
silvio2402
force-pushed
the
extension-formatting
branch
from
80ee2c2 to
06c59fa
Compare
silvio2402
force-pushed
the
extension-formatting
branch
from
06c59fa to
4ee4ba7
Compare
silvio2402
force-pushed
the
extension-formatting
branch
from
4ee4ba7 to
1550768
Compare
tvislavski
approved these changes
Dec 12, 2024
silvio2402
force-pushed
the
extension-formatting
branch
from
9badcdb to
e163288
Compare
mandlil
approved these changes
Dec 18, 2024
giggsey
added a commit
to giggsey/libphonenumber-for-php
that referenced
this pull request
Jan 15, 2025
giggsey
added a commit
to giggsey/libphonenumber-for-php-lite
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure that the extension is not included twice in the formatted number.
Unlike the Java version, the C++ version didn't format extensions at all which is fixed in this change.
Context: b/309836518