Skip to content

fix: update CMakeLists.txt to allow building with REGENERATE_METADATA off#3301

Open
CoolGoose wants to merge 1 commit into
google:masterfrom
CoolGoose:patch-1
Open

fix: update CMakeLists.txt to allow building with REGENERATE_METADATA off#3301
CoolGoose wants to merge 1 commit into
google:masterfrom
CoolGoose:patch-1

Conversation

@CoolGoose

Copy link
Copy Markdown

I am not sure if this is the correct change (since my experience with Cmake is limited) but from my understanding and errors I am getting the current else branch breaks the current generated metadata becasue of the OUTPUT flag.

The "fix" is to just display the skip message in the else, and it proceeds to build without any issues.

@CoolGoose CoolGoose requested a review from a team as a code owner November 21, 2023 10:08
@google-cla

google-cla Bot commented Nov 21, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@CoolGoose

Copy link
Copy Markdown
Author

I am not sure what's wrong with the CLA but it errors out with

Your CLA signature could not be read; please reach out to your contact Googler.

@rfeiner

rfeiner commented Jan 8, 2024

Copy link
Copy Markdown

Any update about this one? 🙏

@katbohm katbohm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants